chore(cli): replace temp with native mkdtemp#7429
Open
Dame5211 wants to merge 1 commit into
Open
Conversation
Constraint: CLI resource generation only needs a temporary directory and the package targets Node versions with native fs.mkdtemp support Rejected: swap temp for another temp-directory package | native Node APIs avoid a direct runtime dependency Confidence: high Scope-risk: narrow Directive: Keep CLI temporary directory handling on native fs APIs unless cleanup semantics change Tested: pnpm --filter @refinedev/cli test -- src/commands/add/sub-commands/resource/index.test.ts Tested: pnpm biome check packages/cli/src/commands/add/sub-commands/resource/create-resources.ts packages/cli/package.json Tested: git diff --check Not-tested: pnpm --filter @refinedev/cli build (declaration generation requires prebuilt devtools workspace packages in this filtered install) Co-authored-by: OmX <omx@oh-my-codex.dev>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
temppackage usage in resource generation with nativefs.mkdtempSyncfs-extrautilitiestempand@types/tempdependencies from@refinedev/cliCloses #7375.
Verification
pnpm --filter @refinedev/cli test -- src/commands/add/sub-commands/resource/index.test.tspnpm biome check packages/cli/src/commands/add/sub-commands/resource/create-resources.ts packages/cli/package.jsongit diff --checkNotes
pnpm --filter @refinedev/cli buildcompleted thetsupCJS/ESM bundle step, then failed during declaration generation because this filtered install did not have prebuilt@refinedev/devtools-serverworkspace declarations available.